Implemented INCREMENTAL_ALTER_CONFIGS api
#939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ALTER_CONFIGS` and `INCREMENTAL_ALTER_CONFIGS` Kafka APIs have almost identical handler logic. Moved `ALTER_CONFIGS` handler logic to utils file, in order to use already existing implementation in both cases. All functions were replaced with function templates as request and responses types are different for both APIs yet they are very similar. Signed-off-by: Michal Maslanka <michal@vectorized.io>
Signed-off-by: Michal Maslanka <michal@vectorized.io>
Added handling of incremental alter configuration Kafka APIs. In contrast to existing alter config API the incremental version allow user to change only subset of available configuration resources. Previous API i.e. `ALTER_CONFIGS` cause all properties to be overridden by request values. To use old alter configs API client have to first describe topic then update single value in topic properties map and request update. Signed-off-by: Michal Maslanka <michal@vectorized.io>
Signed-off-by: Michal Maslanka <michal@vectorized.io>
dotnwat
approved these changes
Mar 24, 2021
I am writing ducktape tests for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
As described in KIP-339 an
IncrementalAlterConfigsAPI provides a way to interact with single property of given configuration resource instead of overriding them all as olderAlterConfigsAPI.Fixes issues: [#935]
Release notes
IncrementalAlterConfigsThis change will provide users way to setup Redpanda topic configurations with standard
kafka-configs.shtool coming from Kafka.