Bug fixes

redphx · Dec 5, 2024 · 5b67c34 · 5b67c34
1 parent e1f8fce
commit 5b67c34
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/dist/better-xcloud.lite.user.js b/dist/better-xcloud.lite.user.js
@@ -4507,7 +4507,8 @@ class SettingsDialog extends NavigationDialog {
    $note,
    multiLines: setting.multiLines
   });
-  $row.htmlFor = `bx_setting_${escapeCssSelector(pref)}`, $row.dataset.type = settingTabContent.group, $tabContent.appendChild($row), !prefDefinition?.unsupported && setting.onCreated && setting.onCreated(setting, $control);
+  if (pref) $row.htmlFor = `bx_setting_${escapeCssSelector(pref)}`;
+  $row.dataset.type = settingTabContent.group, $tabContent.appendChild($row), !prefDefinition?.unsupported && setting.onCreated && setting.onCreated(setting, $control);
  }
  renderSettingsSection(settingTab, sections) {
   let $tabContent = CE("div", {

diff --git a/dist/better-xcloud.user.js b/dist/better-xcloud.user.js
@@ -6413,7 +6413,8 @@ class SettingsDialog extends NavigationDialog {
    $note,
    multiLines: setting.multiLines
   });
-  $row.htmlFor = `bx_setting_${escapeCssSelector(pref)}`, $row.dataset.type = settingTabContent.group, $tabContent.appendChild($row), !prefDefinition?.unsupported && setting.onCreated && setting.onCreated(setting, $control);
+  if (pref) $row.htmlFor = `bx_setting_${escapeCssSelector(pref)}`;
+  $row.dataset.type = settingTabContent.group, $tabContent.appendChild($row), !prefDefinition?.unsupported && setting.onCreated && setting.onCreated(setting, $control);
  }
  renderSettingsSection(settingTab, sections) {
   let $tabContent = CE("div", {

diff --git a/src/modules/ui/dialog/settings-dialog.ts b/src/modules/ui/dialog/settings-dialog.ts
@@ -1007,7 +1007,9 @@ export class SettingsDialog extends NavigationDialog {
             $note,
             multiLines: setting.multiLines,
         });
-        $row.htmlFor = `bx_setting_${escapeCssSelector(pref!)}`;
+        if (pref) {
+            $row.htmlFor = `bx_setting_${escapeCssSelector(pref)}`;
+        }
         $row.dataset.type = settingTabContent.group;
 
         $tabContent.appendChild($row);