Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] "We are sorry..." Error After Changing User Agent to Edge #34

Closed
ILikePlayingGames opened this issue Jul 29, 2023 · 8 comments · Fixed by #48
Closed

[Bug] "We are sorry..." Error After Changing User Agent to Edge #34

ILikePlayingGames opened this issue Jul 29, 2023 · 8 comments · Fixed by #48
Labels
bug Something isn't working

Comments

@ILikePlayingGames
Copy link

Describe the bug
xCloud returns a 404 page after changing the user agent to edge on macOS due to missing window.navigator.platform and window.navigator.userAgentData values

To Reproduce
Steps to reproduce the behavior:

  1. Open xCloud
  2. Change user agent to edge
  3. Save and reload the page

Platform (please complete the following information):

  • OS: macOS Ventura
  • Browser: Safari
  • Browser Version: 16.6
  • Better xCloud Version: 746e32e

Additional context
I also encountered this issue during my testing with changing the user agent. Copying the values from Edge and loading them at document-start resolved it. xCloud appears to use these values as part of the platform detection process.
@ILikePlayingGames ILikePlayingGames added the bug Something isn't working label Jul 29, 2023
@redphx
Copy link
Owner

redphx commented Jul 29, 2023

I also had this issue. Just refresh the page several times and it will be ok again.

@ILikePlayingGames
Copy link
Author

Thanks, refreshing a few times did not work for me initially but I cleared the cookies, set everything up again, and it works now

@redphx
Copy link
Owner

redphx commented Jul 29, 2023 •
edited
Loading

Glad that it worked.
FYI, this feature doesn't really change browser's User-Agent. It only changes the variable that xCloud reads from, so it doesn't affect other sites.

@ILikePlayingGames
Copy link
Author

Thanks, that's good to know

@redphx
Copy link
Owner

redphx commented Jul 29, 2023

Thanks for reporting. I'm gonna close this.

@redphx redphx closed this as completed Jul 29, 2023
@ILikePlayingGames
Copy link
Author

This issue seems to recur after changing to a different network and refreshing the page. Does this happen for you?

@redphx
Copy link
Owner

redphx commented Jul 30, 2023

I reopened the issue. I still got it from time to time but do 1 refresh and it's gone. Maybe xCloud validates something. I need to check.

@redphx redphx reopened this Jul 30, 2023
redphx added a commit that referenced this issue Aug 2, 2023
@redphx
Fix 404 error when spoofing User-Agent (#34)
432feef
@redphx redphx mentioned this issue Aug 2, 2023
Merged
@redphx redphx closed this as completed in #48 Aug 2, 2023
redphx added a commit that referenced this issue Aug 2, 2023
@redphx
Add In/Out badges (#48)
8eb8bbf 
* Show In/Out badges

* Cache DOMs of Stream badges

* Refresh badges every 3s

* Shorten Video badge: "1920x1080" -> "1080p"

* Fix 404 error when spoofing User-Agent (#34)
@ILikePlayingGames
Copy link
Author

@redphx im getting it on iOS safari 16.6 for edge user agent again and it's taking 5-6 refreshes to clear. Can you please check?

@redphx redphx mentioned this issue Aug 15, 2023
Closed
@redphx redphx changed the title [Bug] 404 Error After Changing User Agent to Edge [Bug] "We are sorry..." Error After Changing User Agent to Edge Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add In/Out badges redphx/better-xcloud
2 participants
@redphx @ILikePlayingGames