Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-Ups after mapState #1042

Merged
merged 4 commits into from
Oct 10, 2018
Merged

Conversation

wgao19
Copy link
Contributor

@wgao19 wgao19 commented Oct 8, 2018

What does this PR do?

Regarding #1001, a few follow up fixes on the mapState piece.

Summary of the changes

  • Site header:
    • Remove "Troubleshooting"
    • Uppercase "API"
    • Add "Using React-Redux" and let it direct to the mapState doc
  • Site sidebar:
    • Uppercase "API"
    • Add a dash to "React-Redux"
  • Site footer:
    • Add "Using React-Redux"
    • Align all link labels with section names on the sidebar
  • Doc changes
    • <ConnectedTodo> typo
    • Changed a wording at the table for consistency
    • Add "./using-react-redux" directory and move in mapState.md
    • Add array.slice to the list of options that create new references

@netlify
Copy link

netlify bot commented Oct 8, 2018

Deploy preview for react-redux-docs ready!

Built with commit f24ca6d

https://deploy-preview-1042--react-redux-docs.netlify.com

@wgao19 wgao19 force-pushed the docs/clean-up-mapstate branch from c6ff1d1 to 85c0131 Compare October 8, 2018 15:20
@wgao19 wgao19 force-pushed the docs/clean-up-mapstate branch from 85c0131 to fb9a40c Compare October 8, 2018 15:25
@wgao19
Copy link
Contributor Author

wgao19 commented Oct 8, 2018

Oops I just realized my prettier ran on api.md. Let me revert that.

Revert prettier changes on mapstate
@wgao19 wgao19 force-pushed the docs/clean-up-mapstate branch from 12fec8a to 43f416e Compare October 8, 2018 15:42
@markerikson markerikson merged commit dde1a0a into reduxjs:master Oct 10, 2018
@wgao19 wgao19 deleted the docs/clean-up-mapstate branch October 10, 2018 03:22
albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
## What does this PR do?
Regarding reduxjs#1001, a few follow up fixes on the `mapState` piece.

## Summary of the changes
- Site header:
  - Remove "Troubleshooting"
  - Uppercase "API"
  - Add "Using React-Redux" and let it direct to the `mapState` doc
- Site sidebar:
  - Uppercase "API"
  - Add a dash to "React-Redux"
- Site footer:
  - Add "Using React-Redux"
  - Align all link labels with section names on the sidebar
- Doc changes
  - `<ConnectedTodo>` typo
  - Changed a wording at the table for consistency
  - Add "./using-react-redux" directory and move in mapState.md
  - Add `array.slice` to the list of options that create new references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants