Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use React.createContext() by @markerikson #995

Closed
wants to merge 13 commits into from
Closed

Use React.createContext() by @markerikson #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4e654e2
Copy changes from original v6 experiment branch
markerikson Aug 11, 2018
31fc951
Split Connect into two wrapper components
markerikson Aug 11, 2018
0374936
Clean up and finish reworking Connect and Provider
markerikson Aug 12, 2018
a64103c
Don't call setState in Provider if unmounting
markerikson Aug 12, 2018
ed7a910
Rework tests based on changes to connect and Provider
markerikson Aug 14, 2018
3cf4a0f
Fix lint errors
markerikson Aug 18, 2018
6bfedb1
Add react-is
markerikson Aug 18, 2018
5df5a0f
Add missing functionality for connect and Provider
markerikson Aug 18, 2018
1fe01d0
Borrow a bunch of tests from Greg's 1000 branch
markerikson Aug 18, 2018
0d0360f
Include `react-is` in build output
markerikson Aug 24, 2018
577efb0
Try using a functional component instead of forwardRef
markerikson Aug 24, 2018
7f72494
Temporarily undo all connect wrappings
markerikson Aug 24, 2018
9210282
Make forwardRef optional
markerikson Sep 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 21 additions & 50 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"invariant": "^2.2.4",
"loose-envify": "^1.1.0",
"prop-types": "^15.6.1",
"react-is": "^16.4.2",
"react-lifecycles-compat": "^3.0.0"
},
"devDependencies": {
Expand Down
6 changes: 5 additions & 1 deletion rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ const config = {
replace({
'process.env.NODE_ENV': JSON.stringify(env)
}),
commonjs()
commonjs({
namedExports: {
'node_modules/react-is/index.js': ['isValidElementType'],
}
})
]
}

Expand Down
Loading