Convert tests to use react-testing-library instead of Enzyme #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aaaand we are all green! Merging. |
This was referenced Aug 14, 2018
josepot
pushed a commit
to josepot/react-redux-lean
that referenced
this pull request
Sep 21, 2018
…#998) * Update React to 16.4.2 * Restore other test changes from 5.1.0-test commit * Fix tests that fail due to use of a string ref * Disable <StrictMode> tests for now * Add react-testing-library * Convert Provider tests to RTL * Convert Connect tests to RTL * Remove uses of Enzyme and getTestDeps * Remove Enzyme and react-test-renderer packages * Fix a test lint error * Disable lint warnings about componentWillReceiveProps
josepot
pushed a commit
to josepot/react-redux-lean
that referenced
this pull request
Sep 21, 2018
…#998) * Update React to 16.4.2 * Restore other test changes from 5.1.0-test commit * Fix tests that fail due to use of a string ref * Disable <StrictMode> tests for now * Add react-testing-library * Convert Provider tests to RTL * Convert Connect tests to RTL * Remove uses of Enzyme and getTestDeps * Remove Enzyme and react-test-renderer packages * Fix a test lint error * Disable lint warnings about componentWillReceiveProps
Merged
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
…#998) * Update React to 16.4.2 * Restore other test changes from 5.1.0-test commit * Fix tests that fail due to use of a string ref * Disable <StrictMode> tests for now * Add react-testing-library * Convert Provider tests to RTL * Convert Connect tests to RTL * Remove uses of Enzyme and getTestDeps * Remove Enzyme and react-test-renderer packages * Fix a test lint error * Disable lint warnings about componentWillReceiveProps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaned-up and reworked version of @cellog 's changes from #996 . There were some funky merge issues in that branch/PR, and I wanted to start from a clean slate.
Prior to creating this branch, I reverted our two main source files (
connectAdvanced.jsandProvider.js) back to their 5.0.7 versions, as the5.1.0-test1code has been obviously busted in several ways.This PR cleans up the tests so they're running (including disabling the
<StrictMode>tests for now). I then copied over Greg's work porting the tests to usereact-testing-library, and removed Enzyme.At this point, all the tests should be passing. I did have to temporarily disable the ESLint
react/no-deprecatedrule to get it to stop complaining about our use ofcomponentWillReceiveProps, as that lint error was killing the Travis build.