Pass action to trace (#1100) #1369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Very nice. Would love to see this merged! |
This was referenced Aug 12, 2023
|
Any plan to merge soon ? |
|
Any update on this? |
|
Need this. Zustand isn't very developer friendly without tracing enabled. @meluskyc Can the conflicts be resolved for v5.0.0-alpha.X? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1100
From the docs, the
tracefunction that returns a stack trace is supposed to be passed the action, so this fixes that.This should help some of the new JS state managers support all devtools features.
See:
pmndrs/valtio#331
pmndrs/zustand#716