chore(build): swap in tsdx #212

RichiCoder1 · 2019-10-12T19:30:45Z

There's still work that needs to happen as when I last worked on this there were still some important differences in the output around externals, but I figured I'd issue this PR so one can see the differences in a rough state.

/cc @markerikson

markerikson · 2019-10-12T19:40:53Z

Great, thanks! What are the differences in output atm?

markerikson · 2019-10-13T18:15:17Z

I'm poking around at this, and I'm seeing some failing type tests that... shouldn't be.

In particular, these for createSlice:

  // typings:expect-error
  const stringReducer: Reducer<string, PayloadAction<number>> = slice.reducer
  // typings:expect-error
  const anyActionReducer: Reducer<string, AnyAction> = slice.reducer

@phryneas , any idea why these are failing? Not sure if it's due to a TS update, or the fact that we're using TS directly now.

Also, I see that ts-jest is flagging unused variables in tests as errors, which seems overly strict (especially when a few of the tests are doing things like grabbing extraArg from a thunk and asserting on it, and not using dispatch or getState). That's... annoying.

RichiCoder1 · 2019-10-13T18:24:31Z

Great, thanks! What are the differences in output atm?

I think the biggest difference is you had externals for a few of the packages setup differently than how it's currently configured. I forget the specifics. I think there's also at least one rollup plugin I hadn't brought over yet.

I'm poking around at this, and I'm seeing some failing type tests that... shouldn't be.

In particular, these for createSlice:

Weird. Maybe a typescript bump error?

Also, I see that ts-jest is flagging unused variables in tests as errors, which seems overly strict (especially when a few of the tests are doing things like grabbing extraArg from a thunk and asserting on it, and not using dispatch or getState). That's... annoying.

That should be pretty easy to fix, just need to crank that option down.

markerikson · 2019-10-13T18:33:06Z

Yeah, looking at the build output, the biggest immediate differences I see are:

The names of the UMD files changed (r-s-k.umd[.min].js for current, r-s-k.umd[.development].js for this branch)
The UMD files are no longer embedding the other libs directly, but rather expecting them as globals

I'm not as overly concerned about the UMD naming, especially since this is pre-1.0, but I do want our UMD files to be entirely self-contained (ie, I should be able to link the UMD file and write working Redux code right there).

Also, could we rebase this against the v0.8-integration branch? I'd like to do the 0.8 release with this if we can get it pulled together.

RichiCoder1 · 2019-10-13T18:34:39Z

I think both are those are pretty fixable. Just need to drop the externals plugin from the UMD build and tweak the output name. I can try both those later.

phryneas · 2019-10-13T20:55:56Z

I'm poking around at this, and I'm seeing some failing type tests that... shouldn't be.

Seems to be a bug introduced with TypeScript 3.6. State is inferred to any in that version, no matter what is being passed in. No idea why though. That'll need some investigation.

PS: seems that TS3.6 infers the state type to any because extraReducers is taken into account even though it is optional.
This can be fixed by changing line 69 in createReducer from

  extraReducers?: CaseReducers<State, any>
//to
  extraReducers?: CaseReducers<NoInfer<State>, any>

markerikson · 2019-10-16T01:47:09Z

Bah, closed by the TS fix PR. Reopening.

markerikson · 2019-10-16T04:00:53Z

Welllll, something is definitely still not right here:

    src/createSlice.test.ts:104:42 - error TS2769: No overload matches this call.
      Overload 1 of 2, '(payload?: undefined): WithPayload<undefined, Action<"ADD_MORE">>', gave the following error.
        Argument of type '{ amount: number; }' is not assignable to parameter of type 'undefined'.
      Overload 2 of 2, '(payload?: void | undefined): WithPayload<void, Action<"ADD_MORE">>', gave the following error.
        Argument of type '{ amount: number; }' is not assignable to parameter of type 'void'.
    104       const result = reducer(10, addMore({ amount: 5 }))
                                                 ~~~~~~~~~~~~~

waitasec, that's the thing we just did in 0.8. um...

okay, we've got a createSlice test that's manually calling createAction. Why didn't that fail in the 0.8 branch in the first place? Was it because we weren't on TS 3.6 yet?

netlify · 2019-10-16T04:44:00Z

Deploy preview for redux-starter-kit-docs ready!

Built with commit 0af1c4e

https://deploy-preview-212--redux-starter-kit-docs.netlify.com

markerikson · 2019-10-16T04:46:43Z

Well, it builds now!

I fixed the now-broken uses of createAction, and patched up the types in createReducer.test.ts enough to let it run. (The point of that file is to test behavior, not the types, so I'm not worried if it's a little iffy.)

So, now the question is what the output is like.

I gotta head to bed, but will hopefully be able to look at it again tomorrow.

- Removed "externals" so that all libs get bundled in - Fixed dev UMD output file name

markerikson · 2019-10-17T02:54:01Z

Okay, fixed up the UMD externals and the dev filename. Output now looks basically equivalent to what we have already, minus a few Babel helpers and such.

Also, interestingly, the CJS file appears to already be minified, which is surprising.

I'm going to publish an alpha build and see if we can get some folks to test it out.

markerikson · 2019-10-17T03:38:45Z

Published v0.9.0-alpha.0 as redux-starter-kit@build-test.

Can folks try it out and see how it looks?

phryneas · 2019-10-17T06:54:00Z

You can look at the files in the package over at https://unpkg.com/browse/redux-starter-kit@0.9.0-alpha.0/ :

I'm not really happy that we're shipping the src folder (I already know I'll be importing from there on accident), and in addition to that all those .d.ts files seperately instead of a rolled-up .d.ts (I already know that those will be problems with my babel+babel-preset-typescript webpack setup 😢 ).

@nickmccurdy can we do a rollup from that? This seems to be an open issue with jaredpalmer/tsdx#80 - that's why I personally prefer pika with @pika/plugin-bundle-types over tsdx. But maybe we could take some inspiration from jaredpalmer/tsdx#80 or how @pika/plugin-bundle-types does it?

PS: yes, it already looks like that in older versions, but I'm already doing very weird imports from RSK as I recall. Will check back on those later on work.

phryneas · 2019-10-17T08:15:38Z

As this is a quite exotic case, I've created a reproduction repo here: https://github.com/phryneas/reproduction-non-rollup-types/blob/master/src/index.ts

Given that by now, almost everything is re-exported from index.d.ts, I don't actually think this is too much of a problem any more (it was in the early days of RSK for me and I still have some workarounds for that in place!), but I'd love to see the types as one single file for 1.0.

phryneas · 2019-10-17T19:18:07Z

Oh, and one thing that is definitely a bug and needs to be adressed:
This file https://unpkg.com/browse/redux-starter-kit@0.9.0-alpha.0/dist/index.js links to ./redux-starter-kit.cjs.production.min.js, which does not exist.

markerikson · 2019-10-17T20:06:33Z

@phryneas : y'know, I just realized that's why we only have a minified CJS file. It's because the custom Rollup config is overriding the output in both cases, by reading from one of the package.json fields, and thus the prod build is overwriting the debug build. We'd want to change the package.json field to point to index.js instead.

I'll fix things up this evening, including applying the DTS output, and publish another alpha.

- Removed wrong filename causing CJS dev build to be overwritten - Change package `main` field to point to CJS index file

markerikson · 2019-10-18T02:56:22Z

Been working on this this evening. Fixed the CJS filename, and was working on copying the changes @phryneas suggested.

I just updated TSDX to 0.10.x on general principle... and it looks like it's now bundling all the typedefs into index.d.ts automatically due to a change in Rollup TS plugins, no api-extractor package needed:

jaredpalmer/tsdx#200

jaredpalmer/tsdx#208

Based on that, I'm going to drop it from the setup for now. If someone wants to see what other options it offers down the road, I'm fine with that.

This reverts commit 0be4ea9. Apparently IE11 doesn't support Object.assign(). Oops!

markerikson · 2019-10-18T03:26:24Z

Oooo-kay, and that's completely dying in the tslint check with:

Definition for rule '@typescript-eslint/no-angle-bracket-type-assertion' was not found @typescript-eslint/no-angle-bracket-type-assertion

For every TS source file. What in the world?

markerikson · 2019-10-18T03:34:12Z

Whoa, this is bizarre. That actually showed up previously over in #198 .

Prevents a whole bunch of repeats of this error: Definition for rule '@typescript-eslint/no-angle-bracket-type-assertion' was not found @typescript-eslint/no-angle-bracket-type-assertion

# Conflicts: # package-lock.json # package.json

markerikson · 2019-10-18T03:49:54Z

Still don't know what's causing that weird lint error, but I was able to shut it up by explicitly disabling that lint rule.

markerikson · 2019-10-18T03:59:34Z

yayyyyyy and we're green!

okay, I'm gonna go publish another alpha now.

markerikson · 2019-10-18T04:12:01Z

Okay, v0.9.0-alpha.1 is out. Unpkg looks good:

https://unpkg.com/browse/redux-starter-kit@0.9.0-alpha.1/dist/

markerikson · 2019-10-18T04:26:20Z

Tried forking the last "Advanced Tutorial" sandbox and updating it to v0.9.0-alpha.1. Fixed the slice -> name changes, and it runs.

Any further comments or objections before I merge this in and publish 0.9.0?

Or, should I just go ahead and jump to 1.0.0-rc.0?

phryneas · 2019-10-18T06:09:59Z

I'd publish it as 0.9 - that way we get some real-world feedback until you publish it as 1.0

markerikson · 2019-10-18T15:41:16Z

Agreed. All right, I'll merge this in and put out 0.9.

markerikson · 2019-10-18T16:10:46Z

Published https://github.com/reduxjs/redux-starter-kit/releases/tag/v0.9.0

RichiCoder1 · 2019-10-20T22:22:24Z

@markerikson Glad I could be of help!

markerikson · 2019-10-20T23:47:50Z

Yep, thanks!

chore(build): swap in tsdx

b18f6be

markerikson mentioned this pull request Oct 13, 2019

v0.8 integration #208

Merged

phryneas added a commit to phryneas/redux-toolkit that referenced this pull request Oct 15, 2019

fix(createClice) fix a bug with TS 3.6 (see reduxjs#212)

d1e6d4e

phryneas mentioned this pull request Oct 15, 2019

Fix #212 #214 #215

Merged

markerikson mentioned this pull request Oct 15, 2019

Update Travis to test against multiple versions of TypeScript #216

Closed

markerikson closed this in c56b76b Oct 16, 2019

markerikson reopened this Oct 16, 2019

Merge branch 'master' into switch_to_tsdx

e0793a3

markerikson added 3 commits October 16, 2019 00:15

Fix now-incorrect use of createAction

813da4a

Silence ts-jest warnings about unused variables

657c3a8

Fix up types in tests enough to pass

183e289

markerikson mentioned this pull request Oct 16, 2019

Discussion: Roadmap to 1.0 #82

Closed

12 tasks

markerikson added 2 commits October 16, 2019 22:46

Fix UMD config to match existing behavior

d5397aa

- Removed "externals" so that all libs get bundled in - Fixed dev UMD output file name

Tweak devtools options setup to hopefully work better in IE11

0be4ea9

0.9.0-alpha.0

27a5fbb

markerikson marked this pull request as ready for review October 17, 2019 03:37

markerikson added 3 commits October 17, 2019 22:30

Fix CJS output

58faf4f

- Removed wrong filename causing CJS dev build to be overwritten - Change package `main` field to point to CJS index file

Update TSDX to latest

d751296

Add api-extractor

99db3fa

markerikson added 4 commits October 17, 2019 23:03

Update dist inclusion and typings file

12ff063

Revert "Tweak devtools options setup to hopefully work better in IE11"

30cfc25

This reverts commit 0be4ea9. Apparently IE11 doesn't support Object.assign(). Oops!

Update Immer to 4.0

372a210

Update redux-thunk to latest

24cc499

markerikson added 3 commits October 17, 2019 23:40

Silence a bizarre TSLint "rule not found" error

0b25b37

Prevents a whole bunch of repeats of this error: Definition for rule '@typescript-eslint/no-angle-bracket-type-assertion' was not found @typescript-eslint/no-angle-bracket-type-assertion

Remove api-extractor

fa7c6eb

Merge branch 'master' into switch_to_tsdx

3b60b1f

# Conflicts: # package-lock.json # package.json

Try to fix CI failures under TS 3.3/3.4, attempt 1

0a56b7d

0.9.0-alpha.1

0af1c4e

markerikson merged commit d639996 into reduxjs:master Oct 18, 2019

RichiCoder1 deleted the switch_to_tsdx branch October 20, 2019 22:22

markerikson mentioned this pull request Oct 22, 2019

Investigate switching or updating build tooling #188

Closed

markerikson mentioned this pull request Oct 29, 2019

Rollback #208: Reinstate rollup-plugin-typescript2 jaredpalmer/tsdx#287

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(build): swap in tsdx #212

chore(build): swap in tsdx #212

RichiCoder1 commented Oct 12, 2019

markerikson commented Oct 12, 2019

markerikson commented Oct 13, 2019

RichiCoder1 commented Oct 13, 2019

markerikson commented Oct 13, 2019 •

edited

Loading

RichiCoder1 commented Oct 13, 2019

phryneas commented Oct 13, 2019 •

edited

Loading

markerikson commented Oct 16, 2019

markerikson commented Oct 16, 2019 •

edited

Loading

netlify bot commented Oct 16, 2019 •

edited

Loading

markerikson commented Oct 16, 2019

markerikson commented Oct 17, 2019

markerikson commented Oct 17, 2019

phryneas commented Oct 17, 2019 •

edited

Loading

phryneas commented Oct 17, 2019

phryneas commented Oct 17, 2019

markerikson commented Oct 17, 2019 •

edited

Loading

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019 •

edited

Loading

phryneas commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

RichiCoder1 commented Oct 20, 2019

markerikson commented Oct 20, 2019

chore(build): swap in tsdx #212

chore(build): swap in tsdx #212

Conversation

RichiCoder1 commented Oct 12, 2019

markerikson commented Oct 12, 2019

markerikson commented Oct 13, 2019

RichiCoder1 commented Oct 13, 2019

markerikson commented Oct 13, 2019 • edited Loading

RichiCoder1 commented Oct 13, 2019

phryneas commented Oct 13, 2019 • edited Loading

markerikson commented Oct 16, 2019

markerikson commented Oct 16, 2019 • edited Loading

netlify bot commented Oct 16, 2019 • edited Loading

markerikson commented Oct 16, 2019

markerikson commented Oct 17, 2019

markerikson commented Oct 17, 2019

phryneas commented Oct 17, 2019 • edited Loading

phryneas commented Oct 17, 2019

phryneas commented Oct 17, 2019

markerikson commented Oct 17, 2019 • edited Loading

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019 • edited Loading

phryneas commented Oct 18, 2019

markerikson commented Oct 18, 2019

markerikson commented Oct 18, 2019

RichiCoder1 commented Oct 20, 2019

markerikson commented Oct 20, 2019

markerikson commented Oct 13, 2019 •

edited

Loading

phryneas commented Oct 13, 2019 •

edited

Loading

markerikson commented Oct 16, 2019 •

edited

Loading

netlify bot commented Oct 16, 2019 •

edited

Loading

phryneas commented Oct 17, 2019 •

edited

Loading

markerikson commented Oct 17, 2019 •

edited

Loading

markerikson commented Oct 18, 2019 •

edited

Loading