RFC: add "match" method to actionCreator #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-starter-kit-docs ready! Built with commit a0b2203 https://deploy-preview-239--redux-starter-kit-docs.netlify.com |
phryneas
force-pushed
the
actionCreator-match
branch
from
4e368a3
to
aae4b00
Compare
|
Can you rebase this against master now that #233 got merged in? |
phryneas
force-pushed
the
actionCreator-match
branch
from
aae4b00
to
a0b2203
Compare
|
Rebased 👍 |
|
Looks neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was triggered by #228 and inspired by https://github.com/aikoven/typescript-fsa - their actionCreators have a
matchmethod that works as a type guard and can apparently be used with redux-observable.This would add the same to our actionCreators. What do you think?
I've added a special typeTest for that useCase: https://github.com/phryneas/redux-starter-kit/blob/actionCreator-match/type-tests/files/createAction.typetest.ts#L279-L290