-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document alternative callback-builder-style notation for actions… #268
Conversation
Deploy preview for redux-starter-kit-docs ready! Built with commit e15dfb8 https://deploy-preview-268--redux-starter-kit-docs.netlify.com |
docs/api/createSlice.md
Outdated
@@ -107,6 +115,8 @@ for references in a larger codebase. | |||
import { createSlice } from '@reduxjs/toolkit' | |||
import { createStore, combineReducers } from 'redux' | |||
|
|||
const incrementBy = createAction < number > 'incrementBy' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ummmh... wtf is prettier doing here...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markerikson I can't convince prettier of const incrementBy = createAction<number>('incrementBy')
here...
Do you face the same problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code block is marked as js
, not ts
, so it's being mis-formatted.
And given that we aren't using any other TS in there, the example is kinda inconsistent anyway.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e15dfb8:
|
the missing documentation für #262