Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document alternative callback-builder-style notation for actions… #268

Merged
merged 4 commits into from
Dec 1, 2019

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Dec 1, 2019

the missing documentation für #262

@netlify
Copy link

netlify bot commented Dec 1, 2019

Deploy preview for redux-starter-kit-docs ready!

Built with commit e15dfb8

https://deploy-preview-268--redux-starter-kit-docs.netlify.com

@@ -107,6 +115,8 @@ for references in a larger codebase.
import { createSlice } from '@reduxjs/toolkit'
import { createStore, combineReducers } from 'redux'

const incrementBy = createAction < number > 'incrementBy'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ummmh... wtf is prettier doing here...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markerikson I can't convince prettier of const incrementBy = createAction<number>('incrementBy') here...
Do you face the same problem?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code block is marked as js, not ts, so it's being mis-formatted.

And given that we aren't using any other TS in there, the example is kinda inconsistent anyway.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 1, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e15dfb8:

Sandbox Source
pedantic-paper-xv8e3 Configuration
awesome-lamport-vwhkg Configuration
rsk-github-issues-example Configuration

@markerikson markerikson changed the title document alternative callback-builder-style notation for actionsMap document alternative callback-builder-style notation for actions… Dec 1, 2019
@markerikson markerikson merged commit 9966480 into reduxjs:master Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants