Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchBaseQuery: expose extraOptions to prepareHeaders #4291

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

phryneas
Copy link
Member

Triggered by #4290 and the fact that we had similar asks before. Not sure if the extra generic arg is worth it. Thoughts, @EskiMojo14 & @markerikson ?

Copy link

codesandbox bot commented Mar 21, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

codesandbox-ci bot commented Mar 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 896e4df:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 896e4df
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/670d8107e31278000880b7d1
😎 Deploy Preview https://deploy-preview-4291--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 21, 2024

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit/query (cjs, production.min.cjs) 22.37 KB (-0.02% 🔽)
1. entry point: @reduxjs/toolkit/query/react (cjs, production.min.cjs) 24.39 KB (-0.1% 🔽)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs, production.min.cjs) 9.18 KB (+0.08% 🔺)
3. fetchBaseQuery (.modern.mjs) 4.61 KB (+0.2% 🔺)

Copy link
Collaborator

@EskiMojo14 EskiMojo14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think some solutions are possible with api.endpoint but this is nicer 👍🏻

@phryneas
Copy link
Member Author

Would you prefer it like this or without the generic and just unknown? 🤔

@EskiMojo14
Copy link
Collaborator

definitely the generic

@markerikson markerikson force-pushed the pr/fetchBaseQuery-extraOptions branch from 968c2f6 to 1f38356 Compare July 27, 2024 17:02
@markerikson markerikson merged commit fa0906e into master Oct 14, 2024
80 checks passed
@markerikson markerikson deleted the pr/fetchBaseQuery-extraOptions branch October 14, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants