feat: extend endpoint overrides for openapi codegen #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
sebws
force-pushed
the
feat/openapi-codegen-override-endpoints-filter-params
branch
from
fdb9e20
to
d0d0db1
Compare
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3585e82:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sebws
force-pushed
the
feat/openapi-codegen-override-endpoints-filter-params
branch
from
d0d0db1
to
afd882a
Compare
|
hi there, any chance someone could take a look at this? |
markerikson
force-pushed
the
feat/openapi-codegen-override-endpoints-filter-params
branch
from
afd882a
to
1f6c72e
Compare
|
Should be live in https://github.com/reduxjs/redux-toolkit/releases/tag/%40rtk-query%2Fcodegen-openapi%402.0.0-alpha.0 ! Please try it out and let us know if it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to filter parameters into endpoint overrides for RTK Query codegen for OpenApi schemas.
Both the path parameter and the body parameter aren't included in this, but could possibly be if it is thought that that would be helpful. I wasn't sure they would need to be filtered since they're less likely than other locations to be auto-added by a middleware.
This means it can filter out from the query, header, or cookie as seen in "Parameter Locations" in the OpenAPI spec
It only runs on the first (by order of endpointOverrides array) filter. This was the existing behaviour for query type, and makes enough sense.
Inspired by my issue #4285 and another relevant issue #3006