add ignoredActionPaths to createSerializableStateInvariantMiddleware #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oredActionPaths, update default value, add tests
|
Deploy preview for redux-starter-kit-docs ready! Built with commit 9fb1c29 https://deploy-preview-457--redux-starter-kit-docs.netlify.com |
|
The codesandbox CI build fails because we got a test taking more that 32ms, adding the "check took too long" message to the output. Not really sure how we should handle that :/ Also, shouldn't travis be running? |
markerikson
reviewed
Mar 29, 2020
| } | ||
| const nonSerializableValue = new Map() | ||
|
|
||
| it('default value: meta.arg', () => { |
There was a problem hiding this comment.
Let's throw in a use of createAsyncThunk here and dispatch one of its actions too, just to confirm that we that's consistent.
There was a problem hiding this comment.
I already added that over here:
|
Yeah, not sure why Travis isn't running. |
|
Tests pass locally, so we're good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow configuration of createSerializableStateInvariantMiddleware ignoredActionPaths, update default value, add tests
fixes #453
I've opted for the additional
ignoredActionPathsoption now, but I'm open for discussion :)