Get rid of console warnings in TodoApp of docs (#2711)

* Get rid of console warnings in TodoApp of docs Add default case for `getVisibleTodos` and remove `#` from href in `Link.js` * Update ExampleTodoList.md
reduxjs · Nov 13, 2017 · 12666b9 · 12666b9
1 parent ef2ce0e
commit 12666b9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/docs/basics/ExampleTodoList.md b/docs/basics/ExampleTodoList.md
@@ -182,7 +182,7 @@ const Link = ({ active, children, onClick }) => {
 
   return (
     <a
-      href="#"
+      href=""
       onClick={e => {
         e.preventDefault()
         onClick()
@@ -259,12 +259,13 @@ import TodoList from '../components/TodoList'
 
 const getVisibleTodos = (todos, filter) => {
   switch (filter) {
-    case 'SHOW_ALL':
-      return todos
     case 'SHOW_COMPLETED':
       return todos.filter(t => t.completed)
     case 'SHOW_ACTIVE':
       return todos.filter(t => !t.completed)
+    case 'SHOW_ALL':
+    default:
+      return todos
   }
 }
 

diff --git a/docs/basics/UsageWithReact.md b/docs/basics/UsageWithReact.md
@@ -179,7 +179,7 @@ const Link = ({ active, children, onClick }) => {
 
   return (
     <a
-      href="#"
+      href=""
       onClick={e => {
         e.preventDefault()
         onClick()
@@ -235,12 +235,13 @@ To use `connect()`, you need to define a special function called `mapStateToProp
 ```js
 const getVisibleTodos = (todos, filter) => {
   switch (filter) {
-    case 'SHOW_ALL':
-      return todos
     case 'SHOW_COMPLETED':
       return todos.filter(t => t.completed)
     case 'SHOW_ACTIVE':
       return todos.filter(t => !t.completed)
+    case 'SHOW_ALL':
+    default:
+      return todos
   }
 }