Skip to content

Commit

Permalink
Cleaning up these and some other tests while I'm here
Browse files Browse the repository at this point in the history
  • Loading branch information
timdorr authored Aug 12, 2019
1 parent 001a197 commit 2c24ecc
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions test/combineReducers.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ describe('Utils', () => {
expect(spy.mock.calls[0][0]).toMatch(
/Store does not have a valid reducer/
)

spy.mockClear()
console.error = preSpy
})
Expand Down Expand Up @@ -265,13 +266,16 @@ describe('Utils', () => {
const bar = (state = { bar: 2 }) => state

expect(spy.mock.calls.length).toBe(0)

const reducer = combineReducers({ foo, bar })
const state = { foo: 1, bar: 2, qux: 3 }

reducer(state, {})
reducer(state, {})
reducer(state, {})
reducer(state, {})
expect(spy.mock.calls.length).toBe(1)

reducer({ ...state, baz: 5 }, {})
reducer({ ...state, baz: 5 }, {})
reducer({ ...state, baz: 5 }, {})
Expand All @@ -290,10 +294,14 @@ describe('Utils', () => {
it('should return an updated state when additional reducers are passed to combineReducers', function() {
const originalCompositeReducer = combineReducers({ foo })
const store = createStore(originalCompositeReducer)

store.dispatch(ACTION)

const initialState = store.getState()

store.replaceReducer(combineReducers({ foo, bar }))
store.dispatch(ACTION)

const nextState = store.getState()
expect(nextState).not.toBe(initialState)
})
Expand All @@ -303,31 +311,43 @@ describe('Utils', () => {

const originalCompositeReducer = combineReducers({ foo, bar })
const store = createStore(originalCompositeReducer)

store.dispatch(ACTION)

const initialState = store.getState()

store.replaceReducer(combineReducers({ baz, bar }))
store.dispatch(ACTION)

const nextState = store.getState()
expect(nextState).not.toBe(initialState)
})

it('should return the same state when reducers passed to combineReducers not changed', function() {
const originalCompositeReducer = combineReducers({ foo, bar })
const store = createStore(originalCompositeReducer)

store.dispatch(ACTION)

const initialState = store.getState()

store.replaceReducer(combineReducers({ foo, bar }))
store.dispatch(ACTION)

const nextState = store.getState()
expect(nextState).toBe(initialState)
})

it('should return an updated state when one of more reducers passed to the combineReducers are removed', function() {
const originalCompositeReducer = combineReducers({ foo, bar })
const store = createStore(originalCompositeReducer)

store.dispatch(ACTION)

const initialState = store.getState()

store.replaceReducer(combineReducers({ bar }))

const nextState = store.getState()
expect(nextState).not.toBe(initialState)
})
Expand Down

0 comments on commit 2c24ecc

Please sign in to comment.