Fix TS definitions test for new Dispatch typing (#2674)

* Fix TypeScript definitions test for new Dispatch typing * Be explicit about type parameters
reduxjs · Oct 23, 2017 · a2200d5 · a2200d5
1 parent 80a5ac5
commit a2200d5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/test/typescript/dispatch.ts b/test/typescript/dispatch.ts
@@ -7,8 +7,8 @@ const dispatchResult: Action = dispatch({type: 'TYPE'});
 
 // thunk
 declare module "../../" {
-    export interface Dispatch<S> {
-        <R>(asyncAction: (dispatch: Dispatch<S>, getState: () => S) => R): R;
+    export interface Dispatch<D = Action> {
+        <R>(asyncAction: (dispatch: Dispatch<D>, getState: () => any) => R): R;
     }
 }
 

diff --git a/test/typescript/middleware.ts b/test/typescript/middleware.ts
@@ -4,25 +4,25 @@ import {
 } from "../../"
 
 declare module "../../" {
-    export interface Dispatch<S> {
-        <R>(asyncAction: (dispatch: Dispatch<S>, getState: () => S) => R): R;
+    export interface Dispatch<D = Action> {
+        <R>(asyncAction: (dispatch: Dispatch<D>, getState: () => any) => R): R;
     }
 }
 
-type Thunk<S, O> = (dispatch: Dispatch<S>, getState?: () => S) => O;
+type Thunk<S, O> = (dispatch: Dispatch, getState?: () => S) => O;
 
 const thunkMiddleware: Middleware =
-  <S>({dispatch, getState}: MiddlewareAPI<S>) =>
-    (next: Dispatch<S>) =>
-      <A extends Action, B>(action: A | Thunk<S, B>): B|Action =>
+  <S, A extends Action>({dispatch, getState}: MiddlewareAPI<S>) =>
+    (next: Dispatch<A>) =>
+      <B>(action: A | Thunk<S, B>): B|Action =>
         typeof action === 'function' ?
           (<Thunk<S, B>>action)(dispatch, getState) :
           next(<A>action)
 
 
 const loggerMiddleware: Middleware =
   <S>({getState}: MiddlewareAPI<S>) =>
-    (next: Dispatch<S>) =>
+    (next: Dispatch) =>
       (action: any): any => {
         console.log('will dispatch', action)
 
@@ -51,7 +51,7 @@ const storeWithThunkMiddleware = createStore(
 );
 
 storeWithThunkMiddleware.dispatch(
-  (dispatch: Dispatch<State>, getState: () => State) => {
+  (dispatch: Dispatch, getState: () => State) => {
     const todos: string[] = getState().todos;
     dispatch({type: 'ADD_TODO'})
   }