Fix missed case in "observe" type check (#2919)

* Make sure that assumed TypeError would be thrown * Check that ThrowError would be thrown in case of null observer object * Add null check for subscribe method
reduxjs · Apr 8, 2018 · f81ef8d · f81ef8d
1 parent a804207
commit f81ef8d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/createStore.js b/src/createStore.js
@@ -234,7 +234,7 @@ export default function createStore(reducer, preloadedState, enhancer) {
        * emission of values from the observable.
        */
       subscribe(observer) {
-        if (typeof observer !== 'object') {
+        if (typeof observer !== 'object' || observer === null) {
           throw new TypeError('Expected the observer to be an object.')
         }
 

diff --git a/test/createStore.spec.js b/test/createStore.spec.js
@@ -629,11 +629,15 @@ describe('createStore', () => {
 
         expect(function() {
           obs.subscribe()
-        }).toThrow()
+        }).toThrowError(new TypeError('Expected the observer to be an object.'))
+
+        expect(function() {
+          obs.subscribe(null)
+        }).toThrowError(new TypeError('Expected the observer to be an object.'))
 
         expect(function() {
           obs.subscribe(() => {})
-        }).toThrow()
+        }).toThrowError(new TypeError('Expected the observer to be an object.'))
 
         expect(function() {
           obs.subscribe({})