Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove References to Sanity in Combine Reducers #2334

Closed
seanmhanson opened this issue Apr 3, 2017 · 1 comment
Closed

Remove References to Sanity in Combine Reducers #2334

seanmhanson opened this issue Apr 3, 2017 · 1 comment

Comments

@seanmhanson
Copy link
Contributor

The file combineReducers.js contains language like assertReducerSanity and sanityError that is generally viewed as ableist and potentially offensive to people living with mental illness. In addition, it doesn't accurately describe what we're trying to do in this check, and using an idom like this also makes it less approachable for developers whose first language is not English.

I'll throw a PR up in a second since this is a super tiny change, but I'm proposing to call it assertReducerShape and describe the error as a shapeAssertionError so that we're more precise and more inclusive.

@timdorr
Copy link
Member

timdorr commented Apr 3, 2017

Closing in favor of the PR you opened up. (Thanks for that!)

@timdorr timdorr closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants