Replace sanity language in combineReducers
#2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces `sanityError` and `assertReducerSanity` with more descriptive, more inclusive language that describes what the check is actually doing (checking and asserting the shape).
|
Yep, that's a more accurate description of the check being done and the intended scope. However, I very much disagree with this being ableist language. "Sanity" in this case is the literal definition of the word: "reasonable and rational behavior." That is rather ambiguous in the case of a code assertion (hence, it should be changed), but has nothing to do with inclusion issues or stigmatizing mental disease. |
|
Thanks for the change! I was using the commonly known definition of sanity check and didn't really think about other meanings. I agree the change is for the better. 👍 |
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
This replaces `sanityError` and `assertReducerSanity` with more descriptive, more inclusive language that describes what the check is actually doing (checking and asserting the shape).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #2334
This replaces
sanityErrorandassertReducerSanitywith more descriptive, less ableist language that describes what the check is actually doing (checking and asserting the shape). I'm proposing to call itassertReducerShapeand describe the error as ashapeAssertionErrorso that we're more precise and more inclusive at the same time!