Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer action types from combineReducers #3411

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Infer action types from combineReducers #3411

merged 2 commits into from
Apr 23, 2019

Commits on Apr 23, 2019

  1. Infer action types from combineReducers 

    This change allows for `combineReducers` to completely infer both the state and action types for its returned reducer.

From experience with large TypeScript projects, it's common to see that the action type is not explicitly specified, which results in `AnyAction` in the resulting reducer type. Unfortunately, this will propagate through the type inference for `createStore` resulting in `dispatch` being very weakly typed. This change alone causes a chain reaction of a more correctly (and strongly) typed project with regards to Redux.
    @appden
    appden committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    eb2938c View commit details
    Browse the repository at this point in the history

  2. Fix formatting issues.

    @timdorr
    timdorr committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    6fe5614 View commit details
    Browse the repository at this point in the history