Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: keep header searchbar background consistent on mobile #3438

Merged
merged 1 commit into from
May 31, 2019

Conversation

sbaudray
Copy link
Contributor

@sbaudray sbaudray commented May 31, 2019

Resolves https://twitter.com/acemarke/status/1134315647427440642

It does feel weird to have a media rule for both 1023px and 1024px but with 1023px we could observe the wrong color for an instant when resizing the window.

It might be better to enforce the rule on any resolution so it won't break if docusaurus changes the way it handles this?

@netlify
Copy link

netlify bot commented May 31, 2019

Deploy preview for redux-docs ready!

Built with commit ca2bae6

https://deploy-preview-3438--redux-docs.netlify.com

@timdorr
Copy link
Member

timdorr commented May 31, 2019

Any reason not to put it in the 1023px section below that?

@sbaudray
Copy link
Contributor Author

With 1023px we can observe the wrong color for an instant when resizing the window because the docusaurus css rule itself is at 1024px

@timdorr
Copy link
Member

timdorr commented May 31, 2019

Gotcha. Well, it works for now. Thanks!

@timdorr timdorr merged commit fb85759 into reduxjs:master May 31, 2019
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants