Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript): remove typings #3501

Closed
wants to merge 1 commit into from

Conversation

alexkrolick
Copy link

@alexkrolick alexkrolick commented Aug 11, 2019

See #3500

If accepted, someone should probably take the diff over to DefinitelyTyped and get that ready

@alexkrolick
Copy link
Author

Side note: The docs build is complaining about prettier 🤔

BREAKING: remove TypeScript definitions from repo
@nickserv
Copy link
Contributor

nickserv commented Aug 12, 2019

It would be best to wait to merge until the types are published in DefinitelyTyped and then increment the major version number.

@nickserv
Copy link
Contributor

nickserv commented Aug 12, 2019

Side note: The docs build is complaining about prettier 🤔

The build is failing because Prettier is looking for index.d.ts, which doesn't exist.

Try this:

-    "format": "prettier --write \"{src,test}/**/*.{js,ts}\" index.d.ts \"**/*.md\"",
-    "format:check": "prettier --list-different \"{src,test}/**/*.{js,ts}\" index.d.ts \"**/*.md\"",
+    "format": "prettier --write \"{src,test}/**/*.js\" \"**/*.md\"",
+    "format:check": "prettier --list-different \"{src,test}/**/*.js\" \"**/*.md\"",

@nickserv nickserv mentioned this pull request Aug 12, 2019
@timdorr timdorr closed this Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants