Tweak example conventions #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm impatient so I'll just merge it. Feel free to argue afterwards :-) |
|
Don't forget to update the Arguments section in the combineReducers API docs. It still suggests using |
|
@ghengeveld Would you like to make a PR? |
|
Done: #590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So... this is fairly opinionated but I think we need to do this.
Changes:
Rootcomponent is the one that includesProvider, and in more complex cases,Router. We make it clear it's needed because that's what keeps hot reloading working until we fix Find a way to cut getReducer and replaceReducer from the API #350.actionsif you have a tiny project. You'll recognize if it gets out of hand anyway.configureStore()method for easier testing (I'm just renaming it here).import *for reducers. This is one of the most commonly asked questions. Now we'll recommend havingreducers/index.jswithcombineReducerscall so you can more clearly trace where the names are coming from.Umm, that's about it. Everybody on board?