Skip to content

Commit

Permalink
Enable telemetry mock server and check only that packets are received
Browse files Browse the repository at this point in the history
  • Loading branch information
Josh-Walker-GM committed Apr 19, 2023
1 parent 1db02ed commit 0b4e4d7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 45 deletions.
47 changes: 3 additions & 44 deletions .github/actions/telemetry_check/check.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -8,28 +8,6 @@ console.log(
`Telemetry is being redirected to ${process.env.REDWOOD_REDIRECT_TELEMETRY}`
)

// All the fields we expect inside a telemetry packet
const expectedPacketFields = [
'type',
'command',
'duration',
'uid',
'ci',
'redwoodCi',
'NODE_ENV',
'os',
'osVersion',
// "shell", // Not expected on windows
'nodeVersion',
'yarnVersion',
'npmVersion',
'redwoodVersion',
'system',
'complexity',
'sides',
'webBundler',
]

// Setup fake telemetry server
const server = http.createServer((req, res) => {
let data = ''
Expand All @@ -39,27 +17,8 @@ const server = http.createServer((req, res) => {
req.on('end', () => {
res.writeHead(200)
res.end()

const packet = JSON.parse(data)

let hasAllFields = true
for (const field of expectedPacketFields) {
if (packet[field] === undefined) {
hasAllFields = false
console.error(`Telemetry packet is missing field "${field}"`)
}
}

const isCI = packet.ci ?? false

if (hasAllFields && isCI) {
console.log('Valid telemetry received')
process.exit(0)
} else {
console.error('Invalid telemetry received')
console.error(packet)
process.exit(1)
}
console.log('Telemetry packet received')
process.exit(0)
})
})

Expand All @@ -77,7 +36,7 @@ try {
switch (mode) {
case 'crwa':
exitCode = await exec(
`yarn node ./packages/create-redwood-app/dist/create-redwood-app.js ../project-for-telemetry --typescript false --git false --yarn-install true`
`yarn node ./packages/create-redwood-app/dist/create-redwood-app.js ../project-for-telemetry --typescript true --git false --yarn-install true`
)
if (exitCode) {
process.exit(1)
Expand Down
4 changes: 3 additions & 1 deletion packages/create-redwood-app/src/telemetry.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ export async function startTelemetry() {
})
traceExporter = new OTLPTraceExporter({
// TODO: Point this to somewhere permanent
url: 'https://master-axolotl.telemetry-analytics-jgmw.c66.me/v1/traces',
url:
process.env.REDWOOD_REDIRECT_TELEMETRY ||
'https://master-axolotl.telemetry-analytics-jgmw.c66.me/v1/traces',
})
traceProcessor = new BatchSpanProcessor(traceExporter)
traceProvider.addSpanProcessor(traceProcessor)
Expand Down

0 comments on commit 0b4e4d7

Please sign in to comment.