getDuplicateRoutes: Ignore redirects and other unnamed routes (#7564)

packages/internal/src/__tests__/routes-mocked.test.ts

@@ -0,0 +1,50 @@
+jest.mock('../paths', () => ({
+  getPaths: () => ({
+    base: '',
+  }),
+}))
+
+jest.mock('@redwoodjs/structure/dist/model/RWRoute', () => ({
+  RWRoute: {},
+}))
+
+jest.mock('@redwoodjs/structure', () => {
+  return {
+    getProject: () => {
+      return {
+        router: {
+          // <Router useAuth={useAuth}>
+          //   <Route path="/login" page={LoginPage} name="login" />
+          //   <Route path="/" redirect="/dashboard" />
+          //   <Route notfound page={NotFoundPage} />
+          // </Router>
+          routes: [
+            {
+              name: 'login',
+              page_identifier_str: 'LoginPage',
+              path: '/login',
+            },
+            {
+              path: '/',
+            },
+            {
+              page_identifier_str: 'NotFoundPage',
+            },
+          ],
+        },
+      }
+    },
+  }
+})
+
+import { getDuplicateRoutes, warningForDuplicateRoutes } from '../routes'
+
+describe('notfound and redirect routes', () => {
+  it('Detects no duplicate routes', () => {
+    expect(getDuplicateRoutes()).toStrictEqual([])
+  })
+
+  it('Produces the correct warning message', () => {
+    expect(warningForDuplicateRoutes()).toBe('')
+  })
+})

packages/internal/src/routes.ts

@@ -19,8 +19,12 @@ export function getDuplicateRoutes() {
   const duplicateRoutes: RouteInformation[] = []
   const allRoutes: (typeof RWRoute)[] = getProject(getPaths().base).router
     .routes
-  const uniquePathNames = new Set(allRoutes.map((route) => route.name))
-  uniquePathNames.forEach((name) => {
+  const uniqueNames = new Set(
+    allRoutes
+      .filter((route) => route.name !== undefined)
+      .map((route) => route.name)
+  )
+  uniqueNames.forEach((name) => {
     const routesWithName = allRoutes.filter((route) => {
       return route.name === name
     })