Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: CLI commands fail due to unawaited promise (JS projects) #10762

Closed
1 task done
Josh-Walker-GM opened this issue Jun 9, 2024 · 1 comment
Closed
1 task done

[Bug]: CLI commands fail due to unawaited promise (JS projects) #10762

Josh-Walker-GM opened this issue Jun 9, 2024 · 1 comment
Assignees
@Josh-Walker-GM
Labels
bug/needs-info More information is needed for reproduction topic/cli

Comments

@Josh-Walker-GM
Copy link
Collaborator

Josh-Walker-GM commented Jun 9, 2024 •
edited
Loading

What's not working?

#10152 switched the prettify function to be async and that is of course fine. We then had to await the usage of that function now. We did update some at the time and then #10478 updated a lot of the others.

The problem is that #10478 was related to a major version upgrade and so was not cherry picked over into next. This means we have to create the fix against next or in someway backport the current code in main into next to fix this issue.

This only happens in JS projects.

How do we reproduce the bug?

Run CLI commands on the stable release version of redwood, e.g. yarn rw setup mailer.

What's your environment? (If it applies)

No response

Are you interested in working on this?

  • I'm interested in working on this
@Josh-Walker-GM Josh-Walker-GM added the bug/needs-info More information is needed for reproduction label Jun 9, 2024
@Josh-Walker-GM Josh-Walker-GM changed the title [Bug]: CLI commands fail due to unawaited promise [Bug]: CLI commands fail due to unawaited promise (JS projects) Jun 9, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Jun 10, 2024
@dac09 dac09 mentioned this issue Jul 10, 2024
Merged
Josh-Walker-GM added a commit that referenced this issue Jul 10, 2024
@dac09 @Josh-Walker-GM
hotfix(js-setup): Await all transformTSToJS functions (#10930)
7ce152a 
This PR waits all calls to `transformTSToJS` which became async due to
the prettier upgrade explained here:
#10762

Closes #10762
Closes #10929

---------

Co-authored-by: GitHub Actions <>
Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
Josh-Walker-GM added a commit that referenced this issue Jul 10, 2024
@dac09 @Josh-Walker-GM
hotfix(js-setup): Await all transformTSToJS functions (#10930)
04eb4f3 
This PR waits all calls to `transformTSToJS` which became async due to
the prettier upgrade explained here:
#10762

Closes #10762
Closes #10929

---------

Co-authored-by: GitHub Actions <>
Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
@Josh-Walker-GM
Copy link
Collaborator Author

Closed by #10930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Josh-Walker-GM Josh-Walker-GM

Labels
bug/needs-info More information is needed for reproduction topic/cli
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Josh-Walker-GM