Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft - Office Hours: Setup Tailwind CSS after Scaffolding and then Scaffolding did not update styles #4382

Closed
dthyresson opened this issue Feb 4, 2022 · 1 comment · Fixed by #9290
Closed

Draft - Office Hours: Setup Tailwind CSS after Scaffolding and then Scaffolding did not update styles #4382

dthyresson opened this issue Feb 4, 2022 · 1 comment · Fixed by #9290
Labels
bug/confirmed We have confirmed this is a bug

Comments

@dthyresson
Copy link
Contributor

dthyresson commented Feb 4, 2022 •
edited
Loading

If I

  • scaffold a model and used the "standard" css
  • then setup tailwind css
  • then scaffold another model (or force scaffolding)

The scaffold.css does not update to the tailwind version of the stylesheet.
@dthyresson dthyresson self-assigned this Feb 4, 2022
@jtoar jtoar added this to Main May 5, 2022
@jtoar jtoar moved this to Backlog in Main May 5, 2022
@dthyresson dthyresson removed their assignment Jun 29, 2022
@Josh-Walker-GM Josh-Walker-GM mentioned this issue Oct 10, 2023
Merged
@Josh-Walker-GM Josh-Walker-GM added the bug/confirmed We have confirmed this is a bug label Oct 10, 2023
@Josh-Walker-GM
Copy link
Collaborator

Just confirmed this behaviour @dthyresson. I'll use the draft PR to iron out a solution and decide what we want to happen in this sort of situation.

Josh-Walker-GM added a commit that referenced this issue Oct 25, 2023
@Josh-Walker-GM
fix(cli): Tailwind setup updates scaffold.css when needed (#9290)
8e59d91 
**Problem**
The `yarn rw g scaffold ...` command does not update the styling when
you have updated to tailwind with `yarn rw setup ui tailwindcss`.

Fixes #4382 

**Changes**
1. The `yarn rw setup ui tailwindcss` will now prompt to update an
existing `scaffold.css`.
@github-project-automation github-project-automation bot moved this from Backlog to Done in Main Oct 25, 2023
jtoar pushed a commit that referenced this issue Nov 2, 2023
@Josh-Walker-GM @jtoar
fix(cli): Tailwind setup updates scaffold.css when needed (#9290)
7efc95d 
**Problem**
The `yarn rw g scaffold ...` command does not update the styling when
you have updated to tailwind with `yarn rw setup ui tailwindcss`.

Fixes #4382 

**Changes**
1. The `yarn rw setup ui tailwindcss` will now prompt to update an
existing `scaffold.css`.
jtoar pushed a commit that referenced this issue Nov 3, 2023
@Josh-Walker-GM @jtoar
fix(cli): Tailwind setup updates scaffold.css when needed (#9290)
f32e0b3 
**Problem**
The `yarn rw g scaffold ...` command does not update the styling when
you have updated to tailwind with `yarn rw setup ui tailwindcss`.

Fixes #4382 

**Changes**
1. The `yarn rw setup ui tailwindcss` will now prompt to update an
existing `scaffold.css`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed We have confirmed this is a bug
Projects
Main
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): Tailwind setup updates scaffold.css when needed redwoodjs/redwood
2 participants
@dthyresson @Josh-Walker-GM