Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RSC/SSR): pass CLI options through to apiServerHandler #10012

Merged
merged 2 commits into from
Feb 15, 2024
Merged

fix(RSC/SSR): pass CLI options through to apiServerHandler #10012

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7024669
fix(server): pass options through to api server
redwood-bot Feb 14, 2024
d56912a
Merge branch 'main' into server/fix-rsc-ssr-api-server-config
dac09 Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/cli/src/commands/serveBothHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,10 @@ export const bothServerFileHandler = async (argv) => {
}

export const bothSsrRscServerHandler = async (argv) => {
// TODO Allow specifying port, socket and apiRootPath
const apiPromise = apiServerHandler({
...argv,
port: 8911,
apiRootPath: '/',
apiRootPath: argv.apiRootPath,
host: argv.apiHost,
port: argv.apiPort,
})

// TODO More gracefully handle Ctrl-C
Expand Down
Loading