RSC: No basePath arg to serve() #10030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
approved these changes
Feb 19, 2024
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 19, 2024
* 'main' of github.com:redwoodjs/redwood: RSC: No basePath arg to serve() (redwoodjs#10030)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never passed a second arg to
serve, and I don't see a use for it right now. So getting rid of it and makingBASE_PATHa const instead. In the future we might want to make it configurable, but for now a const is good enough