fix(server): prefix port/host with api, fix logging #10035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
added a commit
that referenced
this pull request
Feb 20, 2024
Last fix for v7 I noticed while trying to get #10034 done. In talking to Josh about his experiences deploying to Fly etc and some of the pain points around that, I may introduce a `createServer` for the web side in a minor. If they're in the same file (which they will be for now), parsing argv with just port and host will be a problem. So to avoid that I've made it so that it's apiPort and apiHost.
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 20, 2024
…sc-build * 'feat/rsc-build' of github.com:dac09/redwood: (119 commits) chore(deps): update dependency @playwright/test to v1.41.2 (redwoodjs#10040) chore(crwa): update version in e2e test (redwoodjs#10037) chore(ci): update yarn.lock for changelog action (redwoodjs#10039) chore: bump TSTyche (redwoodjs#10036) chore(changelog): add v7 (redwoodjs#10038) v7.0.0 Version docs to 7.0 chore(docs): align v6 docs with the next branch (redwoodjs#10034) chore(docs): align v6 docs with the next branch (redwoodjs#10034) fix(server): prefix port/host with api, fix logging (redwoodjs#10035) fix(server): prefix port/host with api, fix logging (redwoodjs#10035) docs: Removes warning within Mailer documentation about Studio being experimental (redwoodjs#10033) docs: Within describeScenario documentation, change optimisation to use American English (redwoodjs#10032) docs(metadata): Fix spelling/typos (redwoodjs#10027) chore(release): link to previous releases and upgrade guides in the changelog (redwoodjs#10026) chore(ci): add changelog check to ci (redwoodjs#9989) fix(realtime): update logic for including sseLink (redwoodjs#10025) chore(k6 tests): update entry point (redwoodjs#10024) feat(server): add docs on the server file (redwoodjs#10019) fix(types): Fix TS type in createServer.test.ts (redwoodjs#10023) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last fix for v7 I noticed while trying to get #10034 done. In talking to Josh about his experiences deploying to Fly etc and some of the pain points around that, I may introduce a
createServerfor the web side in a minor. If they're in the same file (which they will be for now), parsing argv with just port and host will be a problem. So to avoid that I've made it so that it's apiPort and apiHost.