Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSC: Remove commented code from worker #10058

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Feb 23, 2024

Cleaning up the rsc worker by removing code that was commented out

@Tobbe Tobbe added changelog-ok release:chore This PR is a chore (means nothing for users) labels Feb 23, 2024
@Tobbe Tobbe added this to the RSC milestone Feb 23, 2024
@Tobbe Tobbe enabled auto-merge (squash) February 23, 2024 10:12
@Tobbe Tobbe merged commit 553f4ac into redwoodjs:main Feb 23, 2024
42 of 49 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-worker-remove-commented-code branch February 23, 2024 10:20
dac09 added a commit to dac09/redwood that referenced this pull request Feb 27, 2024
…onsolidate-vite-settings-rsc-builds

* 'feat/rsc-build' of github.com:dac09/redwood: (34 commits)
  Add support for additional env var files (redwoodjs#9961)
  Revert startsWith change
  Remove outdated todo comment. And other comment formatting
  no more 'as string', and startsWith instead of includes
  innerText
  Update studio.md (redwoodjs#10062)
  doc comment formatting
  node-loader should look in distRsc now, not distServer
  Remove `serve` from test fixture
  Code comment tweaks/fixes
  Update some more comments
  Remove duplicated file
  Lint
  Another rename of build functions
  Fix paths test with new paths
  Rename build functions
  Tobbe review changes
  Apply suggestions from code review
  chore(rename): Be consistent with 'for' prefix for babel plugin option (redwoodjs#10059)
  RSC: Remove commented code from worker (redwoodjs#10058)
  ...
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants