Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSC: Fix server build root #10076

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Feb 29, 2024

root used to be /web, making vite pick up on files both in /dist and /src. We don't want it to process files in /dist, so we set root to /web/src instead.

Because vite picked up on files twice, they were also processed by babel twice. We had code in our cell plugin that depended on the fact that they'd get a second pass. Now that they don't anymore that plugin needed to be updated to work with just a single pass.

@Tobbe Tobbe force-pushed the tobbe-rsc-fix-server-build-root branch from 48468d9 to f46ca53 Compare February 29, 2024 06:02
@Tobbe Tobbe added changelog-ok release:fix This PR is a fix labels Feb 29, 2024
@Tobbe Tobbe added this to the RSC milestone Feb 29, 2024
@Tobbe Tobbe enabled auto-merge (squash) February 29, 2024 06:41
@Tobbe Tobbe merged commit d83d52d into redwoodjs:main Feb 29, 2024
41 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-fix-server-build-root branch February 29, 2024 11:35
dac09 added a commit to dac09/redwood that referenced this pull request Feb 29, 2024
* 'main' of github.com:redwoodjs/redwood:
  RSC: Fix server build root (redwoodjs#10076)
  chore(release): update changelog
  RSC: Add build step debug logs (redwoodjs#10078)
  fix(deploy): handle server file (redwoodjs#10061)
  RSC: Fix node-loader message typo (redwoodjs#10077)
  chore(release): update changelog
  chore(docs): Add link to SuperTokens auth (redwoodjs#10067)
  chore(release): update changelog
  RSC: chore - upgrade @tobbe.dev/rsc-test to v0.0.5 (redwoodjs#10073)
  chore(.vscode): Enable find inside root __fixtures__ (redwoodjs#10072)
  chore(deps): bump es5-ext from 0.10.62 to 0.10.64 (redwoodjs#10071)
  fix(coherence): update setup command to detect server file (redwoodjs#10060)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants