Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSC: setClientEntries: Always 'load', so let's get rid of it #10170

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Mar 9, 2024

Only time we called setClientEntries we always passed 'load' as the value. So let's just get rid of value and change the code to always just run the "load" behavior

@Tobbe Tobbe added changesets-ok Override the changesets check release:fix This PR is a fix release:chore This PR is a chore (means nothing for users) and removed release:fix This PR is a fix labels Mar 9, 2024
@Tobbe Tobbe added this to the RSC milestone Mar 9, 2024
@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) and removed release:chore This PR is a chore (means nothing for users) release:fix This PR is a fix labels Mar 9, 2024
@Tobbe Tobbe enabled auto-merge (squash) March 9, 2024 12:51
@Tobbe Tobbe merged commit 5a7e24f into redwoodjs:main Mar 9, 2024
46 of 66 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-set-client-entries-load branch March 9, 2024 12:59
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants