fix(dbauth-mw): Unset cookie instead of clearing #10502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
commented
Apr 23, 2024
packages/auth-providers/dbAuth/middleware/src/__tests__/createDbAuthMiddleware.test.ts
Outdated
Show resolved
Hide resolved
|
@dthyresson will leave for you to merge just so you're aware. We were missing part of the test case here, otherwise would've caught it! |
Tobbe
reviewed
Apr 24, 2024
|
|
||
| // mwResponse gets converted to a response eventually. | ||
| const finalResponse = res.toResponse() | ||
| expect(finalResponse.headers.getSetCookie()).toEqual([ |
There was a problem hiding this comment.
Suggested change
| expect(finalResponse.headers.getSetCookie()).toEqual([ | |
| // Verify that the cookies were unset | |
| expect(finalResponse.headers.getSetCookie()).toEqual([ |
| // mwResponse gets converted to a response eventually. | ||
| const finalResponse = res.toResponse() | ||
| expect(finalResponse.headers.getSetCookie()).toEqual([ | ||
| // Expired cookies here! |
There was a problem hiding this comment.
Suggested change
| // Expired cookies here! | |
| // Expired cookies with no values |
Comment on lines
526
to
528
| // mwResponse gets converted to a response eventually. | ||
| const finalResponse = res.toResponse() | ||
| expect(finalResponse.headers.getSetCookie()).toEqual([ |
There was a problem hiding this comment.
To be honest the code comment you had was confusing me more than it was helping me. I suggest just getting rid of it and inlining the res.toResponse() part. I think the code speaks for itself here 🙂
Suggested change
| // mwResponse gets converted to a response eventually. | |
| const finalResponse = res.toResponse() | |
| expect(finalResponse.headers.getSetCookie()).toEqual([ | |
| expect(res.toResponse().headers.getSetCookie()).toEqual([ |
dthyresson
reviewed
Apr 24, 2024
Tobbe
approved these changes
Apr 26, 2024
dac09
added a commit
that referenced
this pull request
Apr 26, 2024
…g-gen-mw-p2 * 'main' of github.com:redwoodjs/redwood: RSC: Add RSC+SSR smoke test to CI (#10477) fix(dbauth-mw): Use response passed in to middleware (#10516) Add redwood.toml to `yarn rw info` (#10518) chore(tests): Fix packages/web tests (#10517) fix(dbauth-mw): Unset cookie instead of clearing (#10502) chore(deps): Upgrade to React canary 20240424 (#10513) chore(deps): Upgrade to React Testing Library 14.3.1 (#10514) feat(upgrade): Use GitHub token if available when downloading patches (#10515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dbAuth middleware implementation to unset the cookies, instead of clearing them.
This fixes the case where the cookie should be removed when decryption fails.