Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSC: Remove one level of nesting for server-router #10539

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented May 3, 2024

For the server router we don't need <LocationAwareRouter> because we're not using contexts to store the location – we're passing it in as a prop instead. So this change just simplifies the code a bit to make it easier to read and understand.

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels May 3, 2024
@Tobbe Tobbe added this to the RSC milestone May 3, 2024
@Tobbe Tobbe enabled auto-merge (squash) May 3, 2024 14:20
@Tobbe Tobbe merged commit deed7e8 into redwoodjs:main May 3, 2024
53 of 57 checks passed
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants