Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSC: Extract fetchRsc out into its own file #10689

Merged
merged 3 commits into from
May 28, 2024
Merged

RSC: Extract fetchRsc out into its own file #10689

merged 3 commits into from
May 28, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented May 28, 2024 •
edited
Loading

This PR:

  1. Makes ClientRouter easier to read and understand by making it smaller and by removing RSC fetching code, which is none of its business
  2. Prepares ClientRouter for when RSC fetching is consolidated. Right now there's both the new rscFetch and the old fetchRSC in client.ts. There should eventually only be one of them. When we fix that, the only thing that's going to need to change in ClientRouter is a single import (hopefully)
  3. Removes unrelated code changes from RSC: Include <App> in SSR #10688

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels May 28, 2024
@Tobbe Tobbe added this to the RSC milestone May 28, 2024
@Tobbe Tobbe force-pushed the tobbe-rsc-extract-fetchrsc-for-client-router branch from 16a3897 to 424a9bc Compare May 28, 2024 20:28
@Tobbe Tobbe merged commit 7d60707 into redwoodjs:main May 28, 2024
46 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-extract-fetchrsc-for-client-router branch May 28, 2024 20:56
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobbe @Josh-Walker-GM