-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ssr/rsc): Update tsconfig when enabling streaming-ssr #10701
Conversation
"../api/src/*", | ||
"../.redwood/types/mirror/api/src/*" | ||
], | ||
"$api/*": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please try to keep this file as close as possible to the template in CRWA? So that it's easier for users to see what changes the setup command actually did by just running a git diff
. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. The CRWA template isn't formatted with prettier (which is why you see a big diff. I used prettier on all of the ones I changed.
Would you like me to prettify crwa or change all the others to the unformatted version?
(the ones in the fixture were paritally formatted and not confgruent with crwa)
I don’t care as much about the ones in the fixtures. I mostly care about the diff in users projects when they enable the feature |
|
The jsconfig was already formatted with prettier, no changes in js template |
If you do update the CRWA template you probably need to update our main (old/regular) test project fixture as well. Otherwise everyone going forward will get missmatches there |
Updates the tsconfig.json for
web/tsconfig.json
when enabling streaming-ssrChanges to tsconfig:
This allows us to use the exports fields from package.json