Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ssr/rsc): Update tsconfig when enabling streaming-ssr #10701

Merged
merged 6 commits into from
May 31, 2024

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented May 30, 2024

Updates the tsconfig.json for web/tsconfig.json when enabling streaming-ssr

Changes to tsconfig:

  • sets moduleResolution and module to NodeNext

This allows us to use the exports fields from package.json

@dac09 dac09 added the release:chore This PR is a chore (means nothing for users) label May 30, 2024
@dac09 dac09 added this to the SSR milestone May 30, 2024
@dac09 dac09 self-assigned this May 30, 2024
"../api/src/*",
"../.redwood/types/mirror/api/src/*"
],
"$api/*": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please try to keep this file as close as possible to the template in CRWA? So that it's easier for users to see what changes the setup command actually did by just running a git diff. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Hmm...

Why did you have to do this?

Copy link
Contributor Author

@dac09 dac09 May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. The CRWA template isn't formatted with prettier (which is why you see a big diff. I used prettier on all of the ones I changed.

Would you like me to prettify crwa or change all the others to the unformatted version?

(the ones in the fixture were paritally formatted and not confgruent with crwa)

@Tobbe Tobbe added the changesets-ok Override the changesets check label May 30, 2024
Copy link
Member

Tobbe commented May 30, 2024

I don’t care as much about the ones in the fixtures. I mostly care about the diff in users projects when they enable the feature

Copy link
Member

Tobbe commented May 30, 2024

Would you like me to prettify crwa or change all the others to the unformatted version?
I like pretty things 😄 So please go ahead and prettify crwa 🙂

@dac09 dac09 added the crwa-ok Override the CRWA check label May 30, 2024
@dac09
Copy link
Contributor Author

dac09 commented May 30, 2024

The jsconfig was already formatted with prettier, no changes in js template

Copy link
Member

Tobbe commented May 30, 2024

If you do update the CRWA template you probably need to update our main (old/regular) test project fixture as well. Otherwise everyone going forward will get missmatches there

@Tobbe Tobbe merged commit daf35b0 into redwoodjs:main May 31, 2024
46 checks passed
@Josh-Walker-GM Josh-Walker-GM modified the milestones: SSR, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check crwa-ok Override the CRWA check release:chore This PR is a chore (means nothing for users)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants