Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vite): dist imports from router #10713

Merged
merged 1 commit into from
May 31, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented May 31, 2024

Don't pull in the entire router package, just the specific file we need. Small perf win, but mainly for RSC, so that I don't include client only code like createContext

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels May 31, 2024
@Tobbe Tobbe added this to the RSC milestone May 31, 2024
@Tobbe Tobbe enabled auto-merge (squash) May 31, 2024 21:04
@Tobbe Tobbe merged commit 7058af6 into redwoodjs:main May 31, 2024
46 of 49 checks passed
@Tobbe Tobbe deleted the tobbe-vite-dist-import-router branch May 31, 2024 21:20
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants