Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(imports): Differentiate between React type import and method imports #10721

Merged
merged 1 commit into from
Jun 4, 2024
Merged

chore(imports): Differentiate between React type import and method imports #10721

merged 1 commit into from
Jun 4, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jun 4, 2024

This is mostly a stylistic change. But I do prefer to use named imports from react, so you can see right at the top of the file what methods are used

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Jun 4, 2024
@Tobbe Tobbe added this to the RSC milestone Jun 4, 2024
@Tobbe Tobbe enabled auto-merge (squash) June 4, 2024 14:06
@Tobbe Tobbe merged commit 1f8a16c into redwoodjs:main Jun 4, 2024
46 of 53 checks passed
@Tobbe Tobbe deleted the tobbe-stream-helpers-react-imports branch June 4, 2024 16:03
dac09 added a commit to dac09/redwood that referenced this pull request Jun 7, 2024
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into feat/move-se…
2e174c1 
…rver-store

* 'main' of github.com:redwoodjs/redwood:
  chore(deps): bump @fastify/reply-from from 9.4.0 to 9.8.0 (redwoodjs#10728)
  chore(deps): bump jose from 4.15.4 to 4.15.5 (redwoodjs#10726)
  chore(ci): Track `@redwoodjs/router` in RSC CI (redwoodjs#10727)
  chore(deps): bump ejs from 3.1.9 to 3.1.10 (redwoodjs#10725)
  RSC: Include `<App>` in SSR (redwoodjs#10688)
  chore(logging): Remove overly verbose logging (redwoodjs#10723)
  chore(formatting): Fix "check annotations" (redwoodjs#10722)
  chore(comment): Update comment to match implementation (redwoodjs#10720)
  chore(imports): Differentiate between React type import and method imports (redwoodjs#10721)
  chore(auth): auth-supabase-api dependency fixes (redwoodjs#10719)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobbe @Josh-Walker-GM