Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rename): Rename output to distSsr #10740

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jun 6, 2024

Rename the build output folder to dist/ssr

It used to be dist/server. But "server" is such an ambiguous word now, so it was confusing.

  • Is it "server" because this is the only thing that's run on the server? No. The dist/rsc stuff is also run on the server
  • Is it "server" because it's run with the "react-server" condition? Well, it kind of is, but what we think of as being run with "react-server" is really what's in dist/rsc.
  • Often, when talking in general about RSC people talk about "the server". In fact what they're most likely talking about in that case is "the RSC server", which is actually our standard web server (we use the same server for both RSC and general serving of our web frontend), and that doesn't live in dist/ at all, and absolutely not in dist/server. That server lives in node_modules. When asked for RSC stuff it'll serve files from dist/rsc.

I think dist/ssr is more clear because the stuff in there is used for the client context during the SSR phase, together with the files in dist/rsc for any server components. It's actually much closer to what's in dist/client than anything server-related.

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Jun 6, 2024
@Tobbe Tobbe added this to the RSC milestone Jun 6, 2024
@Tobbe Tobbe merged commit 9303d26 into redwoodjs:main Jun 6, 2024
51 checks passed
@Tobbe Tobbe deleted the tobbe-rename-to-dist-ssr branch June 6, 2024 06:12
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants