Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSC: getLocation in ServerRouter #10759

Merged
merged 10 commits into from
Jun 9, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jun 9, 2024

The client router uses useLocation() to get the location.
Up until very recently there was no way for the server router to get the location, so we had to pass it in as a prop. But thanks to #10697 and #10756 it's now possible to use our serverStore and call getLocation() to give us the info we need.

@Tobbe Tobbe added release:feature This PR introduces a new feature changesets-ok Override the changesets check labels Jun 9, 2024
@Tobbe Tobbe added this to the RSC milestone Jun 9, 2024
@Tobbe Tobbe merged commit 2e72321 into redwoodjs:main Jun 9, 2024
51 checks passed
@Tobbe Tobbe deleted the tobbe-server-router-get-location branch June 9, 2024 08:28
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:feature This PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants