chore(esm/cjs): Make the rwjs/vite package dual #10934
Conversation
Set type
…ore/vitepkg-dual * 'chore/vitepkg-dual' of github.com:dac09/redwood: fix(docs): Fix introduction link (redwoodjs#10938) fix(cli-helpers): Fix CJS support (redwoodjs#10936) chore(cli-helpers): Formatting chore(cli-helpers): loadEnvFiles cleanup (redwoodjs#10935) feat(cli-helpers): Add loadEnvFiles (redwoodjs#10931)
|
Solved it by generating index.cts. Expand for old problem descriptionI can't generate CJS types for the vite package, because it complains about: The problem is that for us to build to ESM, and use exports properly, we have to set the following properties in the tsconfig.json: which means we change the import statements (to have .js, and use exports fields). BUT to generate the CJS types, I need to set in the tsconfig.types-cjs.json I need to se: which doesn't compile in TSC due to the reasons above (a) and (b).... 👎 |
packages/vite/src/plugins/vite-plugin-rsc-routes-auto-loader.ts
Outdated
Show resolved
Hide resolved
…g-dual * 'main' of github.com:redwoodjs/redwood: chore(web): Use attw args instead of custom output parsing (redwoodjs#10944) chore(web): publint and attw (redwoodjs#10943) chore(auth): Fix esm cjs exports and add tooling to verify correctness (redwoodjs#10942) chore(middleware): Move middleware out of rwjs/vite -> rwjs/web/middleware (redwoodjs#10917) feat(colors): Add more chalk colors. And prepare for chalk upgrade (redwoodjs#10939) fix(g directive): Notes formatting (redwoodjs#10940)
…ore/vitepkg-dual * 'chore/vitepkg-dual' of github.com:dac09/redwood: chore(auth): build tweaks and add missing devdep (redwoodjs#10947) chore(web): tsconfig.build.json (redwoodjs#10946)
packages/vite/src/plugins/__tests__/swap-apollo-provider.test.mts
Outdated
Show resolved
Hide resolved
dac09
force-pushed
the
chore/vitepkg-dual
branch
from
8c712bb to
7d2e380
Compare
|
Can you please also add attw and publint tests to the vite package, like I've done for auth, web and project-config? Just to make sure they both agree we got the package.json setup properly |
…g-dual * 'main' of github.com:redwoodjs/redwood: fix(web): Re-add generating ESM types (redwoodjs#10952) chore(project-config): Verify package.json with publint and attw (redwoodjs#10951) chore(apollo client): Add types for cjs imports (redwoodjs#10949) chore(tsconfig.types-cjs): Specify tsBuildInfoFile location (redwoodjs#10950)
Added the scripts. Note the failures are for exports that shouldn't sit in the vite package (I think! - all the router stuff) - or are only imported in ESM. I think I prefer to have the default output from attw, rather than filter out messages - what do you think? I can also add the require ones and generate the .d.ts for them, but in reality we don't want these exports imported in a CJS environment |
…-mw-dualpkg * 'main' of github.com:redwoodjs/redwood: RSC: Fix red squiggles in default template (redwoodjs#10955) chore(supabase-mw): Convert supabase-mw to dual package (redwoodjs#10954) chore(esm/cjs): Make the rwjs/vite package dual (redwoodjs#10934) chore(auth): More gracefully handle build failures (redwoodjs#10953) fix(web): Re-add generating ESM types (redwoodjs#10952) chore(project-config): Verify package.json with publint and attw (redwoodjs#10951) chore(apollo client): Add types for cjs imports (redwoodjs#10949) chore(tsconfig.types-cjs): Specify tsBuildInfoFile location (redwoodjs#10950)
As title
Outstanding:
- [ ] Convert supabase middleware to dual package too, like dbAuth.I had to convert dbAuth middleware, because otherwise the RSC builds fail with "default export not found", when trying to import MiddlewareResponse.I took this out of this PR. I'm going to do this separately, as its not a blocker anymore.