Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): Fix import issues with storybook vite #10961

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

Josh-Walker-GM
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM commented Jul 18, 2024

I was seeing issues with the storybook vite command. It would complain about default with imports.

I have reverted some of your changes here @dac09. Hopefully this is okay? I didn't have a lot of context around the original changes you made but I have reverted here because it fixes the issue I was seeing. Happy for you to correct me if I am taking us in the wrong direction.

I also stole some code from #10768.

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label Jul 18, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the next-release-patch milestone Jul 18, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Jul 18, 2024
@Josh-Walker-GM Josh-Walker-GM merged commit 065e6e6 into main Jul 18, 2024
51 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw/fix-storybook-vite branch July 18, 2024 22:32
@Josh-Walker-GM
Copy link
Collaborator Author

@dac09 I'm going to merge this so I can continue elsewhere but feel free to call me out here if this is wrong and I've merged without a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant