Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test-project): switch to tarsync #10962

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Conversation

Josh-Walker-GM
Copy link
Collaborator

The ts-to-js part of generating a javascript test project was broken. I think this is because it was not properly synced. It was complaining about the typescript prettier plugin. If I recall correctly the issue was because we upgraded to v5 and then you have to use esm which is why we now have a simple string rather than a require statement in the config file.

@Josh-Walker-GM Josh-Walker-GM added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Jul 18, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the chore milestone Jul 18, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Jul 18, 2024
@Josh-Walker-GM Josh-Walker-GM requested a review from dac09 July 18, 2024 22:56
@Josh-Walker-GM Josh-Walker-GM merged commit 4e13f10 into main Jul 19, 2024
51 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw/fix-test-project-js branch July 19, 2024 13:31
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants