Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Document vitest issue in cli-helper test #11032

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 21, 2024

We were running into some type issues when upgrading from vitest v1 to v2.
It's a known issue with vitest, so just working around with @ts-expect-error for now and providing a link to the vitest issue

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Jul 21, 2024
@Tobbe Tobbe added this to the chore milestone Jul 21, 2024
@Tobbe Tobbe merged commit 1085f84 into redwoodjs:main Jul 21, 2024
46 of 49 checks passed
@Tobbe Tobbe deleted the tobbe-cli-helpers-vitest-ts-issue branch July 21, 2024 10:27
dac09 added a commit to dac09/redwood that referenced this pull request Jul 22, 2024
…-dual-pkg

* 'main' of github.com:redwoodjs/redwood:
  fix(deps): update dependency ts-morph to v23 (redwoodjs#11044)
  chore(deps): update dependency typescript to v5.5.3 (redwoodjs#11035)
  Update saving-data.md (redwoodjs#11043)
  chore(deps): update chore (redwoodjs#11042)
  fix(deps): update dependency ts-morph to v22 (redwoodjs#11041)
  fix(deps): update dependency resend to v3 (redwoodjs#11040)
  chore(deps): update dependency lerna to v8.1.7 (redwoodjs#11039)
  fix(deps): update dependency http-proxy-middleware to v3 (redwoodjs#11038)
  chore(deps): update dependency ora to v8 (redwoodjs#11037)
  fix(deps): update dependency uuid to v10 (redwoodjs#11036)
  chore(deps): update dependency jsdom to v24.1.1 (redwoodjs#11033)
  chore(test): Document vitest issue in cli-helper test (redwoodjs#11032)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants