fix: concurrent api builds #11109
Merged
fix: concurrent api builds #11109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trust your thinking on this @callingmedic911 - and don't see any harm in cancelling an existing build if its running. |
dac09
approved these changes
Jul 29, 2024
callingmedic911
added a commit
that referenced
this pull request
Aug 9, 2024
Follow-up to #11109. While working on #11109, I started making changes that turned into a larger refactor, that's why this separate PR: - **Fix:** Centralized debounce logic with precedence of flags (e.g., if a `rebuild: false` call happens while debounced, it takes precedence, even if subsequent debounced calls were with `true`). - Decoupled the build and HTTP server logic in `watch.ts`. The main motivation was to test parts of the build process I modified. This also improves readability with clearer responsibilities. - Added tests for the debounce with precedence logic.
lilpoozie2005
approved these changes
Sep 3, 2024
lilpoozie2005
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few users reported that the API server crashes with the error
EADDRINUSEwhen switching between branches. This issue happens on the API side when:This scenario is common when doing git operations like switching branches or using git stash, where these changes occur simultaneously. When this happens, step 1 triggers a full build (without esbuild's rebuild), and step 2, without canceling the build from step 1, triggers a separate
rebuild. This results in concurrent builds and two instances of the API server trying to start.This PR provides a quick fix for the issue. It's not ideal to cancel a full build (without a rebuild flag) with a rebuild. I created a follow-up PR to address this + refactor the process a bit.