Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(crwrsca): Fix TS issues in index.ts #11133

Merged
merged 1 commit into from
Jul 31, 2024
Merged

chore(crwrsca): Fix TS issues in index.ts #11133

merged 1 commit into from
Jul 31, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 31, 2024

Fix a TS issue in packages/create-redwood-rsc-app/src/index.ts and actually also a control flow issue. If an exception was thrown during args parsing the app wouldn't directly exit. It'd try to run more commands with a broken config

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Jul 31, 2024
@Tobbe Tobbe added this to the chore milestone Jul 31, 2024
@Tobbe Tobbe enabled auto-merge (squash) July 31, 2024 21:52
@Tobbe Tobbe added the fixture-ok Override the test project fixture check label Jul 31, 2024
@Tobbe Tobbe merged commit b11a798 into redwoodjs:main Jul 31, 2024
51 of 55 checks passed
@Tobbe Tobbe deleted the tobbe-crwrsca-index-ts-types branch July 31, 2024 22:06
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilpoozie2005 lilpoozie2005 lilpoozie2005 approved these changes

Assignees
No one assigned
Labels
fixture-ok Override the test project fixture check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tobbe @lilpoozie2005 @Josh-Walker-GM