chore(deps): Upgrade to React 19 RC 20240802 #11150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React has been releasing RCs for a while now. It's time we upgrade to make sure we're still compatible with the latest changes!
For the PR milestone: I wasn't sure what to pick. Upgrading a dependency from one pre-release version to another would normally definitely just be a patch bump for the framework. But RW currently ships with React 18. And upgrading from 18 to 19 would be a breaking change for RW projects. But, as I said, RW ships with 18, and it should continue to do that. So no change at all for RW apps that are not using experimental features.
But now that I think about it, maybe I should have labeled this "experimental breaking", because even though it's just a prerelease to prerelease bump, it does require apps to change their code, because they specify the react version in their own package.json files 🤔
@Josh-Walker-GM I leave it up to you to decide how you want to handle the versioning of RW here and how you want to frame this in our release notes