chore(ci): Print full diff when check-test-project-fixture fails #11164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
added
fixture-ok
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Aug 7, 2024
…rw-uploads * 'feat/rw-uploads' of github.com:dac09/redwood: chore(tsconfig.build): Fix type checking for tests etc (redwoodjs#11167) chore(config): migrate renovate config (redwoodjs#11157) fix(deps): update prisma monorepo to v5.18.0 (redwoodjs#11165) chore(fixture): Rebuild test project fixture (redwoodjs#11166) chore(ci): Print full diff when check-test-project-fixture fails (redwoodjs#11164) chore(rwjs/vite): Rename build script and format source (redwoodjs#11163) chore(tsconfig): Format vite tsconfig (redwoodjs#11162) RSC: RSA: Better match error handling with how we generally do it in RW (redwoodjs#11161) RSC: RSA: Add more comments to the basic 'use server' check (redwoodjs#11160) RSC: RSA: Remove unused check for '$$id' (redwoodjs#11159) RSC: Fix red squiggles in transform client tests (redwoodjs#11156) RSC: Improve type safety in RSC transform plugins (redwoodjs#11155)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
check-test-project-fixtureCI job sometimes fails with false positives. It's not super often, but it's still annoying when it happens.Seeing the full diff hopefully makes it easier to debug exactly why this is happening.
Funnily it actually failed with one of those false positives in this PR 😄
The package.json diff was expected. But the other one is exactly the error I want to track down and fix