Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Comment out unused import line in seed script template #11171

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

Josh-Walker-GM
Copy link
Collaborator

We changed the seed script to no include a bunch of actual database steps but still kept it in as comments to show the user an example of how to do it.

I think instead of adding a skip about the unused import we could just comment it out too. Thoughts @cannikin?

@Josh-Walker-GM Josh-Walker-GM added release:fix This PR is a fix changesets-ok Override the changesets check labels Aug 8, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the next-release milestone Aug 8, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Aug 8, 2024
@Josh-Walker-GM Josh-Walker-GM requested a review from cannikin August 8, 2024 16:04
Copy link
Member

@cannikin cannikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Josh-Walker-GM Josh-Walker-GM merged commit 3bde179 into main Aug 8, 2024
46 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw/seed-template-fix branch August 8, 2024 16:35
dac09 added a commit to dac09/redwood that referenced this pull request Aug 9, 2024
…pload-link

* 'main' of github.com:redwoodjs/redwood:
  refactor: api-server's `watch` build process (redwoodjs#11110)
  fix: Comment out unused import line in seed script template (redwoodjs#11171)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: next-release, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:fix This PR is a fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants